mt76: usb: fix possible NULL pointer dereference in mt76u_mcu_deinit

Fix possible NULL pointer dereference in mt76u_mcu_deinit routine that
can occur if initialization path fails before calling mt76u_mcu_init_rx

Fixes: ee676cd5017c ("mt76: add driver code for MT76x2u based devices")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/usb_mcu.c b/drivers/net/wireless/mediatek/mt76/usb_mcu.c
index 036be4163e69fcea8d0349a1f0316dbe6ffcd0aa..9527e1216f3d10733f7a0a3b30dde86f6f70788c 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/usb_mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/usb_mcu.c
@@ -48,9 +48,11 @@ EXPORT_SYMBOL_GPL(mt76u_mcu_init_rx);
 
 void mt76u_mcu_deinit(struct mt76_dev *dev)
 {
-       struct mt76_usb *usb = &dev->usb;
+       struct mt76u_buf *buf = &dev->usb.mcu.res;
 
-       usb_kill_urb(usb->mcu.res.urb);
-       mt76u_buf_free(&usb->mcu.res);
+       if (buf->urb) {
+               usb_kill_urb(buf->urb);
+               mt76u_buf_free(buf);
+       }
 }
 EXPORT_SYMBOL_GPL(mt76u_mcu_deinit);