pcmcia: avoid static analysis complaint about use-after-free

Coverity complains about a use after free for 'res1' and 'res2' since
we use the value of the pointers in a 'dev_dbg()' after they have been
freed. That's not really a problem, but it still seems cleaner to
defer freeing until we are completely done with the pointers.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c
index 9da9656242af8b327d2859169df0acae2a56fd17..dcce10eb5ad91cd7333720ad44a763a814982fa4 100644 (file)
--- a/drivers/pcmcia/rsrc_nonstatic.c
+++ b/drivers/pcmcia/rsrc_nonstatic.c
@@ -369,12 +369,12 @@ static int do_validate_mem(struct pcmcia_socket *s,
                }
        }
 
-       free_region(res2);
-       free_region(res1);
-
        dev_dbg(&s->dev, "cs: memory probe 0x%06lx-0x%06lx: %p %p %u %u %u",
                base, base+size-1, res1, res2, ret, info1, info2);
 
+       free_region(res2);
+       free_region(res1);
+
        if ((ret) || (info1 != info2) || (info1 == 0))
                return -EINVAL;