projects
/
openwrt
/
staging
/
xback.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3b9bfe8
)
swconfig: fix un-initialized return value
author
Alexander Couzens
<lynxis@fe80.eu>
Fri, 29 Jun 2018 03:27:16 +0000
(
05:27
+0200)
committer
Jo-Philipp Wich
<jo@mein.io>
Tue, 18 Dec 2018 08:44:02 +0000
(09:44 +0100)
Fix CID
1330844
Found-by: Coverity
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
(backported from
e37ad4e5ca2e70387656da81704ee4d4589c6d70
)
package/network/config/swconfig/src/swlib.c
patch
|
blob
|
history
diff --git
a/package/network/config/swconfig/src/swlib.c
b/package/network/config/swconfig/src/swlib.c
index e6e9aead474b5f2177d316a68dad0161b6e952b4..0fb8ebb392c63f6e8a659d5645d22ccc257adc46 100644
(file)
--- a/
package/network/config/swconfig/src/swlib.c
+++ b/
package/network/config/swconfig/src/swlib.c
@@
-92,7
+92,7
@@
swlib_call(int cmd, int (*call)(struct nl_msg *, void *),
struct nl_cb *cb = NULL;
int finished;
int flags = 0;
- int err;
+ int err
= 0
;
msg = nlmsg_alloc();
if (!msg) {
@@
-105,7
+105,8
@@
swlib_call(int cmd, int (*call)(struct nl_msg *, void *),
genlmsg_put(msg, NL_AUTO_PID, NL_AUTO_SEQ, genl_family_get_id(family), 0, flags, cmd, 0);
if (data) {
- if (data(msg, arg) < 0)
+ err = data(msg, arg);
+ if (err < 0)
goto nla_put_failure;
}