drop_monitor: Require CAP_NET_ADMIN for drop monitor configuration
authorIdo Schimmel <idosch@mellanox.com>
Sun, 11 Aug 2019 07:35:49 +0000 (10:35 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Aug 2019 17:53:30 +0000 (10:53 -0700)
Currently, the configure command does not do anything but return an
error. Subsequent patches will enable the command to change various
configuration options such as alert mode and packet truncation.

Similar to other netlink-based configuration channels, make sure only
users with the CAP_NET_ADMIN capability set can execute this command.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/drop_monitor.c

index 1cf4988de591f47caeecd78c57c701c221446962..cd2f3069f34ea65c033ed398e34f105836c509ff 100644 (file)
@@ -409,6 +409,7 @@ static const struct genl_ops dropmon_ops[] = {
                .cmd = NET_DM_CMD_CONFIG,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
                .doit = net_dm_cmd_config,
+               .flags = GENL_ADMIN_PERM,
        },
        {
                .cmd = NET_DM_CMD_START,