gpio: max732x: Fix I2C dummy device resource leak on probe failure
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Thu, 6 Mar 2014 09:31:15 +0000 (10:31 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 12 Mar 2014 13:48:13 +0000 (14:48 +0100)
In max732x_probe() driver allocates dummy I2C device (if number of ports
is greater than 8) however it is not unregistered if probe fails later.
Fix the leak by unregistering dummy I2C device if it was allocated.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-max732x.c

index 36cb290764b6fc6f13b341af7452cfc9145d1f28..74432daaf6564c21477cb7e739ec3429231f65fc 100644 (file)
@@ -647,6 +647,8 @@ static int max732x_probe(struct i2c_client *client,
        return 0;
 
 out_failed:
+       if (chip->client_dummy)
+               i2c_unregister_device(chip->client_dummy);
        max732x_irq_teardown(chip);
        return ret;
 }