Revert "drm/i915/fbc: Allow on unfenced surfaces, for recent gen"
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 24 Aug 2016 18:00:53 +0000 (19:00 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 24 Aug 2016 18:32:35 +0000 (19:32 +0100)
This reverts commit 8678fdaf396c ("drm/i915/fbc: Allow on unfenced surfaces,
for recent gen") as Skylake has issues with unfenced FBC tracking (and
yes Skylake doesn't even enable FBC yet). Paulo would like to do a full
review of all existing workarounds to see if any more are missing prior
to allowing FBC on unfenced surfaces. In the meantime lets hope that all
framebuffers are idle and naturally fit within the mappable aperture.

Requested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Fixes: 8678fdaf396c ("drm/i915/fbc: Allow on unfenced surfaces...");
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20160824180053.24239-1-chris@chris-wilson.co.uk
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/intel_fbc.c

index bf8b22ad9aed854d2f7ce79a45ac85ec1857ad2a..faa67624e1ed734b80b0c0b9734b63c173d9389c 100644 (file)
@@ -799,10 +799,8 @@ static bool intel_fbc_can_activate(struct intel_crtc *crtc)
         */
        if (cache->fb.tiling_mode != I915_TILING_X ||
            cache->fb.fence_reg == I915_FENCE_REG_NONE) {
-               if (INTEL_GEN(dev_priv) < 5) {
-                       fbc->no_fbc_reason = "framebuffer not tiled or fenced";
-                       return false;
-               }
+               fbc->no_fbc_reason = "framebuffer not tiled or fenced";
+               return false;
        }
        if (INTEL_INFO(dev_priv)->gen <= 4 && !IS_G4X(dev_priv) &&
            cache->plane.rotation != DRM_ROTATE_0) {