net/ibm/emac: use swap() in emac_make_bootlist()
authorFabian Frederick <fabf@skynet.be>
Wed, 10 Jun 2015 16:33:16 +0000 (18:33 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Jun 2015 22:19:41 +0000 (15:19 -0700)
Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/emac/core.c

index b9df0cbd0a3833321d1f73bc74258b50b137f225..b60a34d982a90f6eff42601d8ee0e29a7d356c5d 100644 (file)
@@ -2999,7 +2999,7 @@ static struct platform_driver emac_driver = {
 static void __init emac_make_bootlist(void)
 {
        struct device_node *np = NULL;
-       int j, max, i = 0, k;
+       int j, max, i = 0;
        int cell_indices[EMAC_BOOT_LIST_SIZE];
 
        /* Collect EMACs */
@@ -3026,12 +3026,8 @@ static void __init emac_make_bootlist(void)
        for (i = 0; max > 1 && (i < (max - 1)); i++)
                for (j = i; j < max; j++) {
                        if (cell_indices[i] > cell_indices[j]) {
-                               np = emac_boot_list[i];
-                               emac_boot_list[i] = emac_boot_list[j];
-                               emac_boot_list[j] = np;
-                               k = cell_indices[i];
-                               cell_indices[i] = cell_indices[j];
-                               cell_indices[j] = k;
+                               swap(emac_boot_list[i], emac_boot_list[j]);
+                               swap(cell_indices[i], cell_indices[j]);
                        }
                }
 }