gfs2: Remove vestigial bd_ops
authorBob Peterson <rpeterso@redhat.com>
Fri, 16 Nov 2018 20:18:32 +0000 (14:18 -0600)
committerAndreas Gruenbacher <agruenba@redhat.com>
Tue, 11 Dec 2018 20:43:58 +0000 (21:43 +0100)
Field bd_ops was set but never used, so I removed it, and all
code supporting it.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/incore.h
fs/gfs2/log.c
fs/gfs2/trans.c

index 888b62cfd6d1a8366c7837f9b37d51d4118e275f..663759abe60d74a2ded5f1b8542b9b9dd8c237a2 100644 (file)
@@ -165,7 +165,6 @@ struct gfs2_bufdata {
        u64 bd_blkno;
 
        struct list_head bd_list;
-       const struct gfs2_log_operations *bd_ops;
 
        struct gfs2_trans *bd_tr;
        struct list_head bd_ail_st_list;
index 4dcd2b48189e91b8fd31b2f00bd74f52fd2ed92c..5bfaf381921a1d7b8e99d6f3b931359579103a8d 100644 (file)
@@ -605,7 +605,6 @@ void gfs2_add_revoke(struct gfs2_sbd *sdp, struct gfs2_bufdata *bd)
        bd->bd_blkno = bh->b_blocknr;
        gfs2_remove_from_ail(bd); /* drops ref on bh */
        bd->bd_bh = NULL;
-       bd->bd_ops = &gfs2_revoke_lops;
        sdp->sd_log_num_revoke++;
        atomic_inc(&gl->gl_revokes);
        set_bit(GLF_LFLUSH, &gl->gl_flags);
index 423bc2d03dd82cba438acc9f74c731e049f7e41c..cd9a94a6b5bb10ab589b56f4f9a854cf1cfeb4a5 100644 (file)
@@ -124,15 +124,13 @@ void gfs2_trans_end(struct gfs2_sbd *sdp)
 }
 
 static struct gfs2_bufdata *gfs2_alloc_bufdata(struct gfs2_glock *gl,
-                                              struct buffer_head *bh,
-                                              const struct gfs2_log_operations *lops)
+                                              struct buffer_head *bh)
 {
        struct gfs2_bufdata *bd;
 
        bd = kmem_cache_zalloc(gfs2_bufdata_cachep, GFP_NOFS | __GFP_NOFAIL);
        bd->bd_bh = bh;
        bd->bd_gl = gl;
-       bd->bd_ops = lops;
        INIT_LIST_HEAD(&bd->bd_list);
        bh->b_private = bd;
        return bd;
@@ -169,7 +167,7 @@ void gfs2_trans_add_data(struct gfs2_glock *gl, struct buffer_head *bh)
                gfs2_log_unlock(sdp);
                unlock_buffer(bh);
                if (bh->b_private == NULL)
-                       bd = gfs2_alloc_bufdata(gl, bh, &gfs2_databuf_lops);
+                       bd = gfs2_alloc_bufdata(gl, bh);
                else
                        bd = bh->b_private;
                lock_buffer(bh);
@@ -210,7 +208,7 @@ void gfs2_trans_add_meta(struct gfs2_glock *gl, struct buffer_head *bh)
                unlock_buffer(bh);
                lock_page(bh->b_page);
                if (bh->b_private == NULL)
-                       bd = gfs2_alloc_bufdata(gl, bh, &gfs2_buf_lops);
+                       bd = gfs2_alloc_bufdata(gl, bh);
                else
                        bd = bh->b_private;
                unlock_page(bh->b_page);