extcon: max77693: fix handling return value of regmap_irq_get_virq
authorAndrzej Hajda <a.hajda@samsung.com>
Mon, 14 Dec 2015 11:12:42 +0000 (12:12 +0100)
committerChanwoo Choi <cw00.choi@samsung.com>
Tue, 15 Dec 2015 01:02:23 +0000 (10:02 +0900)
The function can return negative values, so its result should
be assigned to signed variable.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-max77693.c

index 44c499e1beeedbca5bfd7bc1a25641645a1f9a0c..fdf8f5d4d4e9ff72aaac992756d1b18792fe4d98 100644 (file)
@@ -1127,11 +1127,11 @@ static int max77693_muic_probe(struct platform_device *pdev)
        /* Support irq domain for MAX77693 MUIC device */
        for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) {
                struct max77693_muic_irq *muic_irq = &muic_irqs[i];
-               unsigned int virq = 0;
+               int virq;
 
                virq = regmap_irq_get_virq(max77693->irq_data_muic,
                                        muic_irq->irq);
-               if (!virq)
+               if (virq <= 0)
                        return -EINVAL;
                muic_irq->virq = virq;