media: pci: cx23885: Replace mdelay() with msleep() and usleep_range() in altera_ci_s...
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 03:09:46 +0000 (23:09 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 27 Jul 2018 12:12:39 +0000 (08:12 -0400)
altera_ci_slot_reset() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cx23885/altera-ci.c

index 70aec9bb7e959c243073a7487b9326323c0b732d..62bc8049b320122d397ff18eeb06562311c724fa 100644 (file)
@@ -346,7 +346,7 @@ static int altera_ci_slot_reset(struct dvb_ca_en50221 *en50221, int slot)
        mutex_unlock(&inter->fpga_mutex);
 
        for (;;) {
-               mdelay(50);
+               msleep(50);
 
                mutex_lock(&inter->fpga_mutex);