perf hists: Free unused mem info of a matched hist entry
authorNamhyung Kim <namhyung.kim@lge.com>
Mon, 1 Apr 2013 11:35:18 +0000 (20:35 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 28 May 2013 13:23:52 +0000 (16:23 +0300)
The mem info is shared between matched entries so one should be freed.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1364816125-12212-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/hist.c

index 9438d576459d83ec08474347ff76fc4abf450211..514fc0470e3888b18601cf095737d4ca3123df37 100644 (file)
@@ -374,6 +374,12 @@ static struct hist_entry *add_hist_entry(struct hists *hists,
                if (!cmp) {
                        he_stat__add_period(&he->stat, period, weight);
 
+                       /*
+                        * This mem info was allocated from machine__resolve_mem
+                        * and will not be used anymore.
+                        */
+                       free(entry->mem_info);
+
                        /* If the map of an existing hist_entry has
                         * become out-of-date due to an exec() or
                         * similar, update it.  Otherwise we will