V4L/DVB (9419): Bug: unnecessary large current causes large phasor errors
authorManu Abraham <abraham.manu@gmail.com>
Mon, 8 Oct 2007 22:04:03 +0000 (19:04 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 29 Dec 2008 19:53:18 +0000 (17:53 -0200)
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/frontends/tda8261.c

index 9cbd511d749e914338b1d20cfa6786fe163a2296..1b9f4dc1b0032db8c1aec6c797d9659e448b9af5 100644 (file)
@@ -130,6 +130,10 @@ static int tda8261_set_state(struct dvb_frontend *fe,
                 * (to account for half channel spacing on either side)
                 */
                frequency = tstate->frequency;
+               if ((frequency < 950000) || (frequency > 2150000)) {
+                       printk("%s: Frequency beyond limits, frequency=%d\n", __func__, frequency);
+                       return -EINVAL;
+               }
                N = (frequency + (div_tab[config->step_size] - 1)) / div_tab[config->step_size];
                printk("%s: Step size=%d, Divider=%d, PG=0x%02x (%d)\n",
                        __func__, config->step_size, div_tab[config->step_size], N, N);
@@ -137,7 +141,14 @@ static int tda8261_set_state(struct dvb_frontend *fe,
                buf[0] = (N >> 8) & 0xff;
                buf[1] = N & 0xff;
                buf[2] = (0x01 << 7) | ((ref_div[config->step_size] & 0x07) << 1);
-               buf[3] = 0xc0;
+
+               if (frequency < 1450000)
+                       buf[3] = 0x00;
+               if (frequency < 2000000)
+                       buf[3] = 0x40;
+               if (frequency < 2150000)
+                       buf[3] = 0x80;
+
                /* Set params */
                if ((err = tda8261_write(state, buf)) < 0) {
                        printk("%s: I/O Error\n", __func__);