USB: ohci-dbg.c: move assignment out of if () block

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/host/ohci-dbg.c b/drivers/usb/host/ohci-dbg.c
index 04f2186939d24681f582b591a8011c3516e6c933..c3eded317495252ccc731ec9f96096da4ab59a88 100644 (file)
--- a/drivers/usb/host/ohci-dbg.c
+++ b/drivers/usb/host/ohci-dbg.c
@@ -491,7 +491,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf)
        char                    *next;
        unsigned                i;
 
-       if (!(seen = kmalloc (DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC)))
+       seen = kmalloc(DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC);
+       if (!seen)
                return 0;
        seen_count = 0;
 
@@ -506,7 +507,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf)
        /* dump a snapshot of the periodic schedule (and load) */
        spin_lock_irqsave (&ohci->lock, flags);
        for (i = 0; i < NUM_INTS; i++) {
-               if (!(ed = ohci->periodic [i]))
+               ed = ohci->periodic[i];
+               if (!ed)
                        continue;
 
                temp = scnprintf (next, size, "%2d [%3d]:", i, ohci->load [i]);