drm/vc4: Move the DSI clock divider workaround closer to the clock call.
authorEric Anholt <eric@anholt.net>
Tue, 15 Aug 2017 23:47:18 +0000 (16:47 -0700)
committerEric Anholt <eric@anholt.net>
Fri, 13 Oct 2017 23:37:09 +0000 (16:37 -0700)
We want the adjusted_mode->clock to be the actual clock we're
expecting to program, so that consumers see the right values for clock
and vrefresh.

Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20170815234722.20700-1-eric@anholt.net
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/gpu/drm/vc4/vc4_dsi.c

index 925c726ac69417d70a8027d2651ccecf6bdd17a5..554605af344e489c7e77b6032e60e0c90e6481b5 100644 (file)
@@ -859,11 +859,7 @@ static bool vc4_dsi_encoder_mode_fixup(struct drm_encoder *encoder,
        pll_clock = parent_rate / divider;
        pixel_clock_hz = pll_clock / dsi->divider;
 
-       /* Round up the clk_set_rate() request slightly, since
-        * PLLD_DSI1 is an integer divider and its rate selection will
-        * never round up.
-        */
-       adjusted_mode->clock = pixel_clock_hz / 1000 + 1;
+       adjusted_mode->clock = pixel_clock_hz / 1000;
 
        /* Given the new pixel clock, adjust HFP to keep vrefresh the same. */
        adjusted_mode->htotal = adjusted_mode->clock * mode->htotal /
@@ -901,7 +897,11 @@ static void vc4_dsi_encoder_enable(struct drm_encoder *encoder)
                vc4_dsi_dump_regs(dsi);
        }
 
-       phy_clock = pixel_clock_hz * dsi->divider;
+       /* Round up the clk_set_rate() request slightly, since
+        * PLLD_DSI1 is an integer divider and its rate selection will
+        * never round up.
+        */
+       phy_clock = (pixel_clock_hz + 1000) * dsi->divider;
        ret = clk_set_rate(dsi->pll_phy_clock, phy_clock);
        if (ret) {
                dev_err(&dsi->pdev->dev,