drm/amd/display: Use correct error codes

Should return -ENOMEM when allocation fails.
Also, just return the error code instead of using a variable.

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 914cd3f8500a96843d949dbff0f0cd6bbc4e8533..a215e2bbf2fbf5d21b30f98922d799b8249d50c1 100644 (file)
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4761,10 +4761,8 @@ static int dm_update_planes_state(struct dc *dc,
                        WARN_ON(dm_new_plane_state->dc_state);
 
                        dc_new_plane_state = dc_create_plane_state(dc);
-                       if (!dc_new_plane_state) {
-                               ret = -EINVAL;
-                               return ret;
-                       }
+                       if (!dc_new_plane_state)
+                               return -ENOMEM;
 
                        DRM_DEBUG_DRIVER("Enabling DRM plane: %d on DRM crtc %d\n",
                                        plane->base.id, new_plane_crtc->base.id);
@@ -4793,8 +4791,7 @@ static int dm_update_planes_state(struct dc *dc,
                                        dm_state->context)) {
 
                                dc_plane_state_release(dc_new_plane_state);
-                               ret = -EINVAL;
-                               return ret;
+                               return -EINVAL;
                        }
 
                        dm_new_plane_state->dc_state = dc_new_plane_state;