batman-adv: Avoid relation operator comparison with bool

commit 785ea1144182 ("batman-adv: Distributed ARP Table - create DHT helper
functions") introduced a return check of batadv_compare_eth which uses a
boolean return value since commit 16af73458aca ("batman-adv: main,
batadv_compare_eth return bool"). A relational (<, >, <= or >=) operator
is not the right one for such a check.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Acked-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index 19b15de455ab6b3495737592a04e14901fc7ff74..4469dcc1558f9991f309a91a4b0250e5c0818483 100644 (file)
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -495,7 +495,7 @@ static bool batadv_is_orig_node_eligible(struct batadv_dat_candidate *res,
         * the one with the lowest address
         */
        if (tmp_max == max && max_orig_node &&
-           batadv_compare_eth(candidate->orig, max_orig_node->orig) > 0)
+           batadv_compare_eth(candidate->orig, max_orig_node->orig))
                goto out;
 
        ret = true;