drm/i915: Remove intel_panel_detect()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 17 Jul 2018 17:42:16 +0000 (20:42 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 19 Jul 2018 15:39:31 +0000 (18:39 +0300)
With neither LVDS or eDP no longer using intel_panel_detect() we can
kill it, and the accompanying modparam.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180717174216.22252-3-ville.syrjala@linux.intel.com
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/i915_params.c
drivers/gpu/drm/i915/i915_params.h
drivers/gpu/drm/i915/intel_drv.h
drivers/gpu/drm/i915/intel_panel.c

index 817576701ed7565c94f5e378506066e4f346a92b..295e981e4a398c242d10bd6ed446aeb0bfecdc70 100644 (file)
@@ -44,10 +44,6 @@ i915_param_named(modeset, int, 0400,
        "Use kernel modesetting [KMS] (0=disable, "
        "1=on, -1=force vga console preference [default])");
 
-i915_param_named_unsafe(panel_ignore_lid, int, 0600,
-       "Override lid status (0=autodetect, 1=autodetect disabled [default], "
-       "-1=force lid closed, -2=force lid open)");
-
 i915_param_named_unsafe(enable_dc, int, 0400,
        "Enable power-saving display C-states. "
        "(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6)");
index aebe0469ddaa3e36af1568f42721d09aa9b40025..6c4d4a21474b5ffaa9954a145068b1d3effce694 100644 (file)
@@ -36,7 +36,6 @@ struct drm_printer;
 #define I915_PARAMS_FOR_EACH(param) \
        param(char *, vbt_firmware, NULL) \
        param(int, modeset, -1) \
-       param(int, panel_ignore_lid, 1) \
        param(int, lvds_channel_mode, 0) \
        param(int, panel_use_ssc, -1) \
        param(int, vbt_sdvo_panel_type, -1) \
index 92b68ebc7413b5997a391b7c7bd6762bb2238092..edcfd85e7b944749b4493dbf5fd5718d206c20fe 100644 (file)
@@ -1889,7 +1889,6 @@ void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
                                  const struct drm_connector_state *conn_state);
 void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state);
 void intel_panel_destroy_backlight(struct drm_connector *connector);
-enum drm_connector_status intel_panel_detect(struct drm_i915_private *dev_priv);
 extern struct drm_display_mode *intel_find_panel_downclock(
                                struct drm_i915_private *dev_priv,
                                struct drm_display_mode *fixed_mode,
index 14b827ec5427394629f0257d21ec5893411fd0bb..4a9f139e7b7383c8f244bac833679c3b5302214b 100644 (file)
@@ -375,26 +375,6 @@ out:
        pipe_config->gmch_pfit.lvds_border_bits = border;
 }
 
-enum drm_connector_status
-intel_panel_detect(struct drm_i915_private *dev_priv)
-{
-       /* Assume that the BIOS does not lie through the OpRegion... */
-       if (!i915_modparams.panel_ignore_lid && dev_priv->opregion.lid_state) {
-               return *dev_priv->opregion.lid_state & 0x1 ?
-                       connector_status_connected :
-                       connector_status_disconnected;
-       }
-
-       switch (i915_modparams.panel_ignore_lid) {
-       case -2:
-               return connector_status_connected;
-       case -1:
-               return connector_status_disconnected;
-       default:
-               return connector_status_unknown;
-       }
-}
-
 /**
  * scale - scale values from one range to another
  * @source_val: value in range [@source_min..@source_max]