dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet
authorBarry Song <21cnbao@gmail.com>
Fri, 17 Aug 2018 13:03:43 +0000 (06:03 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 3 Sep 2018 10:54:05 +0000 (16:24 +0530)
as you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_xdmac.c

index 4bf72561667c7bd636749f37373477d5a8862f99..4e557684f792d74f493abf922fbef63ed9045b63 100644 (file)
@@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data)
                if (atchan->status & AT_XDMAC_CIS_ROIS)
                        dev_err(chan2dev(&atchan->chan), "request overflow error!!!");
 
-               spin_lock_bh(&atchan->lock);
+               spin_lock(&atchan->lock);
                desc = list_first_entry(&atchan->xfers_list,
                                        struct at_xdmac_desc,
                                        xfer_node);
@@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data)
                txd = &desc->tx_dma_desc;
 
                at_xdmac_remove_xfer(atchan, desc);
-               spin_unlock_bh(&atchan->lock);
+               spin_unlock(&atchan->lock);
 
                if (!at_xdmac_chan_is_cyclic(atchan)) {
                        dma_cookie_complete(txd);