null_blk: fix softirq completions for queue_mode == 1
authorJens Axboe <axboe@fb.com>
Mon, 16 Jun 2014 17:40:25 +0000 (11:40 -0600)
committerJens Axboe <axboe@fb.com>
Mon, 16 Jun 2014 17:40:25 +0000 (11:40 -0600)
Only blk-mq completions have payload attached to the request, for
request_fn mode we have stored it in req->special. This fixes an
oops with queue_mode=1 and softirq completions.

Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/null_blk.c

index f87c4c4c1c410a09b5234b744f28a2b9b9c9995c..a3b042c4d448dcb4ad0a21272dd8ff83527f3b9d 100644 (file)
@@ -227,7 +227,10 @@ static void null_cmd_end_timer(struct nullb_cmd *cmd)
 
 static void null_softirq_done_fn(struct request *rq)
 {
-       end_cmd(blk_mq_rq_to_pdu(rq));
+       if (queue_mode == NULL_Q_MQ)
+               end_cmd(blk_mq_rq_to_pdu(rq));
+       else
+               end_cmd(rq->special);
 }
 
 static inline void null_handle_cmd(struct nullb_cmd *cmd)