modpost: simplify file name generation of *.mod.c files
authorMathias Krause <minipli@googlemail.com>
Wed, 27 Aug 2014 10:58:56 +0000 (20:28 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Wed, 27 Aug 2014 12:24:11 +0000 (21:54 +0930)
Avoid the variable length array (vla), just use PATH_MAX instead.
This not only makes this code clang friedly, it also leads to a
code size reduction:

   text    data     bss     dec     hex filename
  51765    2224   12416   66405   10365 scripts/mod/modpost.old
  51677    2224   12416   66317   1030d scripts/mod/modpost.new

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
scripts/mod/modpost.c

index c2ebdc788f4c22eaa740f12edb8e51499034b3a4..3b405c726ec51ab48e0de2c517b028f748994334 100644 (file)
@@ -2212,7 +2212,7 @@ int main(int argc, char **argv)
        err = 0;
 
        for (mod = modules; mod; mod = mod->next) {
-               char fname[strlen(mod->name) + 10];
+               char fname[PATH_MAX];
 
                if (mod->skip)
                        continue;