net: marvell: convert to DEFINE_SHOW_ATTRIBUTE
authorYangtao Li <tiny.windzz@gmail.com>
Mon, 3 Dec 2018 14:34:11 +0000 (09:34 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Dec 2018 01:33:44 +0000 (17:33 -0800)
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/skge.c
drivers/net/ethernet/marvell/sky2.c

index 9c08c3650c02cdc28cc83f682447dfece1327c65..04fd1f135011f1a068bbc79991af0d05a7c56583 100644 (file)
@@ -3732,19 +3732,7 @@ static int skge_debug_show(struct seq_file *seq, void *v)
 
        return 0;
 }
-
-static int skge_debug_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, skge_debug_show, inode->i_private);
-}
-
-static const struct file_operations skge_debug_fops = {
-       .owner          = THIS_MODULE,
-       .open           = skge_debug_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(skge_debug);
 
 /*
  * Use network device events to create/remove/rename
index c7cd0081058e5b98a8330c04ac076ece1bdcbb3e..f3a5fa84860f907748e702fb11521ff625d0f340 100644 (file)
@@ -4621,19 +4621,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
        napi_enable(&hw->napi);
        return 0;
 }
-
-static int sky2_debug_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, sky2_debug_show, inode->i_private);
-}
-
-static const struct file_operations sky2_debug_fops = {
-       .owner          = THIS_MODULE,
-       .open           = sky2_debug_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(sky2_debug);
 
 /*
  * Use network device events to create/remove/rename