spi: fsl-espi: remove unneeded variable in fsl_espi_do_trans
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 25 Aug 2016 04:45:55 +0000 (06:45 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 1 Sep 2016 20:15:58 +0000 (21:15 +0100)
Creating a message, adding one transfer, and then iterating over
all transfers in the message doesn't make sense.
We can simply use the original transfer directly.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-espi.c

index 0290178186857111d92b12b3eab0933b350c8eea..f9ef50444447e465138bc64000b81e9ae9827359 100644 (file)
@@ -258,11 +258,9 @@ static void fsl_espi_do_trans(struct spi_message *m,
        struct spi_device *spi = m->spi;
        struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
        struct fsl_espi_transfer *espi_trans = tr;
-       struct spi_message message;
        struct spi_transfer *t, *first, trans;
        int status = 0;
 
-       spi_message_init(&message);
        memset(&trans, 0, sizeof(trans));
 
        first = list_first_entry(&m->transfers, struct spi_transfer,
@@ -284,23 +282,18 @@ static void fsl_espi_do_trans(struct spi_message *m,
        trans.len = espi_trans->len;
        trans.tx_buf = espi_trans->tx_buf;
        trans.rx_buf = espi_trans->rx_buf;
-       spi_message_add_tail(&trans, &message);
 
-       list_for_each_entry(t, &message.transfers, transfer_list) {
-               if (t->bits_per_word || t->speed_hz)
-                       fsl_espi_setup_transfer(spi, t);
+       if (trans.bits_per_word || trans.speed_hz)
+               fsl_espi_setup_transfer(spi, &trans);
 
-               if (t->len)
-                       status = fsl_espi_bufs(spi, t);
+       if (trans.len)
+               status = fsl_espi_bufs(spi, &trans);
 
-               if (status) {
-                       status = -EMSGSIZE;
-                       break;
-               }
+       if (status)
+               status = -EMSGSIZE;
 
-               if (t->delay_usecs)
-                       udelay(t->delay_usecs);
-       }
+       if (trans.delay_usecs)
+               udelay(trans.delay_usecs);
 
        espi_trans->status = status;
        fsl_espi_setup_transfer(spi, NULL);