ASoC: sti: Use snd_pcm_stop_xrun() helper
authorTakashi Iwai <tiwai@suse.de>
Wed, 4 Jul 2018 14:01:45 +0000 (16:01 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 4 Jul 2018 14:41:35 +0000 (15:41 +0100)
The XRUN trigger from the driver should be done via
snd_pcm_stop_xrun().  It fixes the missing stream locking as a gratis,
too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sti/uniperif_player.c
sound/soc/sti/uniperif_reader.c

index d8b6936e544e3c9e42444130f9087dc31be73357..313dab2857ef9152435649aafb5c0ed744e4e545 100644 (file)
@@ -91,7 +91,7 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id)
                        SET_UNIPERIF_ITM_BCLR_FIFO_ERROR(player);
 
                        /* Stop the player */
-                       snd_pcm_stop(player->substream, SNDRV_PCM_STATE_XRUN);
+                       snd_pcm_stop_xrun(player->substream);
                }
 
                ret = IRQ_HANDLED;
@@ -105,7 +105,7 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id)
                SET_UNIPERIF_ITM_BCLR_DMA_ERROR(player);
 
                /* Stop the player */
-               snd_pcm_stop(player->substream, SNDRV_PCM_STATE_XRUN);
+               snd_pcm_stop_xrun(player->substream);
 
                ret = IRQ_HANDLED;
        }
@@ -138,7 +138,7 @@ static irqreturn_t uni_player_irq_handler(int irq, void *dev_id)
                dev_err(player->dev, "Underflow recovery failed\n");
 
                /* Stop the player */
-               snd_pcm_stop(player->substream, SNDRV_PCM_STATE_XRUN);
+               snd_pcm_stop_xrun(player->substream);
 
                ret = IRQ_HANDLED;
        }
index ee0055e608529195fda9b76a4226ebf752ead6e3..7b63d35ef428bc6727178ff0d5900ecf7ea8fd4d 100644 (file)
@@ -65,7 +65,7 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id)
        if (unlikely(status & UNIPERIF_ITS_FIFO_ERROR_MASK(reader))) {
                dev_err(reader->dev, "FIFO error detected\n");
 
-               snd_pcm_stop(reader->substream, SNDRV_PCM_STATE_XRUN);
+               snd_pcm_stop_xrun(reader->substream);
 
                ret = IRQ_HANDLED;
        }