media: staging: atomisp: avoid a warning if 32 bits build
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Mar 2018 19:06:00 +0000 (15:06 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 11:36:28 +0000 (07:36 -0400)
Checking if a size_t value is bigger than ULONG_INT only makes
sense if building on 64 bits, as warned by:
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:697 gmin_get_config_var() warn: impossible condition '(*out_len > (~0)) => (0-u32max > u32max)'

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

index be0c5e11e86bb2ee3d09db9550f49647c05fa184..3283c1b05d6ab0bd7f771ab12314117d89377fd0 100644 (file)
@@ -693,9 +693,11 @@ static int gmin_get_config_var(struct device *dev, const char *var,
        for (i = 0; i < sizeof(var8) && var8[i]; i++)
                var16[i] = var8[i];
 
+#ifdef CONFIG_64BIT
        /* To avoid owerflows when calling the efivar API */
        if (*out_len > ULONG_MAX)
                return -EINVAL;
+#endif
 
        /* Not sure this API usage is kosher; efivar_entry_get()'s
         * implementation simply uses VariableName and VendorGuid from