projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5e172f7
)
9p: acl: fix uninitialized iattr access
author
Dominique Martinet
<dominique.martinet@cea.fr>
Fri, 7 Sep 2018 15:10:57 +0000
(
00:10
+0900)
committer
Dominique Martinet
<dominique.martinet@cea.fr>
Fri, 7 Sep 2018 16:51:50 +0000
(
01:51
+0900)
iattr is passed to v9fs_vfs_setattr_dotl which does send various
values from iattr over the wire, even if it tells the server to
only look at iattr.ia_valid fields this could leak some stack data.
Link:
http://lkml.kernel.org/r/1536339057-21974-2-git-send-email-asmadeus@codewreck.org
Addresses-Coverity-ID:
1195601
("Uninitalized scalar variable")
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
fs/9p/acl.c
patch
|
blob
|
history
diff --git
a/fs/9p/acl.c
b/fs/9p/acl.c
index 082d227fa56b378772883f3a4254e7fd05c436d5..6261719f6f2a133c1f059cebaf470f3e28ef0b1c 100644
(file)
--- a/
fs/9p/acl.c
+++ b/
fs/9p/acl.c
@@
-276,7
+276,7
@@
static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
switch (handler->flags) {
case ACL_TYPE_ACCESS:
if (acl) {
- struct iattr iattr;
+ struct iattr iattr
= { 0 }
;
struct posix_acl *old_acl = acl;
retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);