ext4: fix ZERO_RANGE test failure in data journalling
authorNamjae Jeon <namjae.jeon@samsung.com>
Tue, 27 May 2014 16:48:55 +0000 (12:48 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 27 May 2014 16:48:55 +0000 (12:48 -0400)
xfstests generic/091 is failing when mounting ext4 with data=journal.
I think that this regression is same problem that occurred prior to collapse
range issue. So ZERO RANGE also need to call ext4_force_commit as
collapse range.

Cc: stable@vger.kernel.org
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c

index 5bbe425640dacd2af968f06466ccec010b415097..4da228a0e6d02f3cbd1e680e181f3ed88a82f6f3 100644 (file)
@@ -4741,6 +4741,13 @@ static long ext4_zero_range(struct file *file, loff_t offset,
        if (!S_ISREG(inode->i_mode))
                return -EINVAL;
 
+       /* Call ext4_force_commit to flush all data in case of data=journal. */
+       if (ext4_should_journal_data(inode)) {
+               ret = ext4_force_commit(inode->i_sb);
+               if (ret)
+                       return ret;
+       }
+
        /*
         * Write out all dirty pages to avoid race conditions
         * Then release them.