staging: rtlwifi: don't check the return value of debugfs_create_file
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 May 2018 14:29:36 +0000 (16:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Jun 2018 08:47:43 +0000 (10:47 +0200)
We never did anything with the return value, and it does not matter if
the call succeeds or not (it's just debugging code), so don't even check
it.

Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: "Frank A. Cancio Bello" <frank@generalsoftwareinc.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtlwifi/debug.c

index bf360f855c12b47122bb981969ae7d82827b562e..8999feda29b4b4ddfbd308a142d55f7ab6b1dc36 100644 (file)
@@ -521,12 +521,9 @@ static const struct file_operations file_ops_common_rw = {
 #define RTL_DEBUGFS_ADD_CORE(name, mode, fopname)                         \
        do {                                                               \
                rtl_debug_priv_ ##name.rtlpriv = rtlpriv;                  \
-               if (!debugfs_create_file(#name, mode,                      \
-                                        parent, &rtl_debug_priv_ ##name,  \
-                                        &file_ops_ ##fopname))            \
-                       pr_err("Unable to initialize debugfs:%s/%s\n",     \
-                              rtlpriv->dbg.debugfs_name,                  \
-                              #name);                                     \
+               debugfs_create_file(#name, mode, parent,                   \
+                                   &rtl_debug_priv_ ##name,               \
+                                   &file_ops_ ##fopname);                 \
        } while (0)
 
 #define RTL_DEBUGFS_ADD(name)                                             \