iwlwifi: mvm: sanity check context in iwl_mvm_phy_ctxt_unref()
authorJohannes Berg <johannes.berg@intel.com>
Wed, 8 May 2013 13:55:31 +0000 (15:55 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 14 May 2013 08:42:55 +0000 (10:42 +0200)
In some botched (!) restart scenarios we seem to get here with
a NULL PHY context, so warn and exit instead of crashing.

Reported-by: Omer Kremer <omerx.kremer@intel.com>
Reviewed-by: Ilan Peer <ilan.peer@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/iwlwifi/mvm/phy-ctxt.c

index 0ea61aaf7754abfafaeb4ccc721b2ce4b3cd26ab..1b4db25d53fbab1272b0b6d1bbdf145349121502 100644 (file)
@@ -245,5 +245,9 @@ int iwl_mvm_phy_ctxt_changed(struct iwl_mvm *mvm, struct iwl_mvm_phy_ctxt *ctxt,
 void iwl_mvm_phy_ctxt_unref(struct iwl_mvm *mvm, struct iwl_mvm_phy_ctxt *ctxt)
 {
        lockdep_assert_held(&mvm->mutex);
+
+       if (WARN_ON_ONCE(!ctxt))
+               return;
+
        ctxt->ref--;
 }