hwmon: (nct6775) Set weight source to zero correctly
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 5 Sep 2018 07:46:27 +0000 (10:46 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 5 Sep 2018 21:47:50 +0000 (14:47 -0700)
This is dead code because j can never be 1 at this point.  We had
intended to just test if the bit was clear.

Fixes: bbd8decd4123 ("hwmon: (nct6775) Add support for weighted fan control")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nct6775.c

index 944f5b63aecd706228ebcd3a128e3ec488bf63ba..139781ae830ba18a5ceaed217ab0a72430107ccd 100644 (file)
@@ -1558,7 +1558,7 @@ static void nct6775_update_pwm(struct device *dev)
                reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]);
                data->pwm_weight_temp_sel[i] = reg & 0x1f;
                /* If weight is disabled, report weight source as 0 */
-               if (j == 1 && !(reg & 0x80))
+               if (!(reg & 0x80))
                        data->pwm_weight_temp_sel[i] = 0;
 
                /* Weight temp data */