spi: armada-3700: Remove spi_master_put in a3700_spi_remove()
authorWei Yongjun <weiyongjun1@huawei.com>
Sun, 5 Feb 2017 15:49:40 +0000 (15:49 +0000)
committerMark Brown <broonie@kernel.org>
Sun, 19 Feb 2017 16:10:44 +0000 (16:10 +0000)
The call to spi_master_put() in a3700_spi_remove() is redundant since
the master is registered using devm_spi_register_master() and no
reference hold by using spi_master_get() in a3700_spi_remove().

This is detected by Coccinelle semantic patch.

Fixes: 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-armada-3700.c

index 3155ab7ad9707dde5a7bb3dc43d9f1b7f155c517..56acd3511f73f3fb3ba241feb5d29bb8b80480a7 100644 (file)
@@ -901,7 +901,6 @@ static int a3700_spi_remove(struct platform_device *pdev)
        struct a3700_spi *spi = spi_master_get_devdata(master);
 
        clk_unprepare(spi->clk);
-       spi_master_put(master);
 
        return 0;
 }