x86, xsave: clear the user buffer before doing fxsave/xsave
authorSuresh Siddha <suresh.b.siddha@intel.com>
Wed, 13 Aug 2008 18:38:14 +0000 (11:38 -0700)
committerIngo Molnar <mingo@elte.hu>
Thu, 14 Aug 2008 08:56:06 +0000 (10:56 +0200)
fxsave/xsave instructions will not touch all the bytes in the
fxsave/xsave frame. Clear the user buffer before doing fxsave/xsave
directly to user buffer during the sigcontext setup.

This is essentially needed in the context of xsave(for example,
some of the fields in the xsave header are not touched by the xsave
and defined as must be zero).

This will also present uniform and clean context to the user (from
which user can safely do fxrstor/xrstor).

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/xsave.c

index 7415f3e38a5160a9fc9914345f1c1efcc8be0606..bb097b1644d832025a6bc453ad158fdd45d8daa0 100644 (file)
@@ -92,6 +92,12 @@ int save_i387_xstate(void __user *buf)
                return 0;
        clear_used_math(); /* trigger finit */
        if (task_thread_info(tsk)->status & TS_USEDFPU) {
+               /*
+                * Start with clearing the user buffer. This will present a
+                * clean context for the bytes not touched by the fxsave/xsave.
+                */
+               __clear_user(buf, sig_xstate_size);
+
                if (task_thread_info(tsk)->status & TS_XSAVE)
                        err = xsave_user(buf);
                else