ipmi: Remove warning if no slave address is present
authorCorey Minyard <cminyard@mvista.com>
Wed, 24 Apr 2019 17:21:13 +0000 (12:21 -0500)
committerCorey Minyard <cminyard@mvista.com>
Wed, 24 Apr 2019 17:29:24 +0000 (12:29 -0500)
It's just noise, really, lots of systems don't have it.

Reported-by: Kamlakant Patel <kamlakantp@marvell.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_si_platform.c
drivers/char/ipmi/ipmi_ssif.c

index 54c7ded2a1ff80c04f7ac82954da7ef171e56aee..f2a91c4d8cab6074c9a1d1d6686ee1f5daf6dde4 100644 (file)
@@ -188,12 +188,10 @@ static int platform_ipmi_probe(struct platform_device *pdev)
                return -EINVAL;
 
        rv = device_property_read_u8(&pdev->dev, "slave-addr", &slave_addr);
-       if (rv) {
-               dev_warn(&pdev->dev, "device has no slave-addr property\n");
+       if (rv)
                io.slave_addr = 0x20;
-       } else {
+       else
                io.slave_addr = slave_addr;
-       }
 
        io.irq = platform_get_irq(pdev, 0);
        if (io.irq > 0)
index be329f791c95ef8e646dd0df2e83641221f70937..cf8156d6bc07d3cd9b7f38578d94ac44d72d97ba 100644 (file)
@@ -1995,7 +1995,7 @@ static int dmi_ipmi_probe(struct platform_device *pdev)
 
        rv = device_property_read_u8(&pdev->dev, "slave-addr", &slave_addr);
        if (rv)
-               dev_warn(&pdev->dev, "device has no slave-addr property");
+               slave_addr = 0x20;
 
        return new_ssif_client(i2c_addr, NULL, 0,
                               slave_addr, SI_SMBIOS, &pdev->dev);