net: hns: fixes the bug tested XGE by ethtool -p
authorLi Peng <lipeng321@huawei.com>
Tue, 27 Oct 2015 09:17:40 +0000 (17:17 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Oct 2015 03:15:34 +0000 (20:15 -0700)
delete action of ETHTOOL_ID_ON/ETHTOOL_ID_OFF in XGE ethtool -p,
so Hardware control the LED state instead of software.

Signed-off-by: Li Peng <lipeng321@huawei.com>
Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
Signed-off-by: yankejian <yankejian@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c

index d611388aecef17f3721cfd67c11194398f47c429..523e9b83d30429c7e39884c4503d55c4bca38210 100644 (file)
@@ -64,17 +64,10 @@ int cpld_set_led_id(struct hns_mac_cb *mac_cb,
        switch (status) {
        case HNAE_LED_ACTIVE:
                mac_cb->cpld_led_value = dsaf_read_b(mac_cb->cpld_vaddr);
-               return 2;
-       case HNAE_LED_ON:
                dsaf_set_bit(mac_cb->cpld_led_value, DSAF_LED_ANCHOR_B,
                             CPLD_LED_ON_VALUE);
                dsaf_write_b(mac_cb->cpld_vaddr, mac_cb->cpld_led_value);
-               break;
-       case HNAE_LED_OFF:
-               dsaf_set_bit(mac_cb->cpld_led_value, DSAF_LED_ANCHOR_B,
-                            CPLD_LED_DEFAULT_VALUE);
-               dsaf_write_b(mac_cb->cpld_vaddr, mac_cb->cpld_led_value);
-               break;
+               return 2;
        case HNAE_LED_INACTIVE:
                dsaf_set_bit(mac_cb->cpld_led_value, DSAF_LED_ANCHOR_B,
                             CPLD_LED_DEFAULT_VALUE);