ramips: dts: rt5350: reset FE and ESW cores together
authorLech Perczak <lech.perczak@gmail.com>
Mon, 11 Dec 2023 23:25:02 +0000 (00:25 +0100)
committerHauke Mehrtens <hauke@hauke-m.de>
Fri, 5 Jan 2024 22:32:59 +0000 (23:32 +0100)
Failing to do so will cause the DMA engine to not initialize properly
and fail to forward packets between them, and in some cases will cause
spurious transmission with size exceeding allowed packet size, causing a
kernel panic.

This is behaviour of downstream driver as well, however I
haven't observed bug reports about this SoC in the wild, so this
commit's purpose is to align this chip with all other SoC's - MT7620
were already using this arrangement.

Fixes: #9284
Fixes: 60fadae62b64 ("ramips: ethernet: ralink: move reset of the esw into the esw instead of fe")
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
(cherry picked from commit fc92fecfc7ddf19bbfd7d1305a29c666f00543af)
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
target/linux/ramips/dts/rt5350.dtsi

index 090e755743bacdeb63bc0920bfab293560cd8b79..fe43de87cae96272d3e87ee9612f64619d3c52f9 100644 (file)
                compatible = "ralink,rt5350-eth";
                reg = <0x10100000 0x10000>;
 
-               resets = <&rstctrl 21>;
-               reset-names = "fe";
+               resets = <&rstctrl 21>, <&rstctrl 23>;
+               reset-names = "fe", "esw";
 
                interrupt-parent = <&cpuintc>;
                interrupts = <5>;
                compatible = "ralink,rt5350-esw", "ralink,rt3050-esw";
                reg = <0x10110000 0x8000>;
 
-               resets = <&rstctrl 23 &rstctrl 24>;
-               reset-names = "esw", "ephy";
+               resets = <&rstctrl 24>;
+               reset-names = "ephy";
 
                interrupt-parent = <&intc>;
                interrupts = <17>;