projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2c60b68
)
gianfar: Fix use-after-of_node_put() in gfar_of_init().
author
David S. Miller
<davem@davemloft.net>
Sun, 29 Mar 2009 08:19:37 +0000
(
01:19
-0700)
committer
David S. Miller
<davem@davemloft.net>
Sun, 29 Mar 2009 08:19:37 +0000
(
01:19
-0700)
We can't put 'mdio' until after we've used it in the
fsl_pq_mdio_bus_name() call.
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/gianfar.c
patch
|
blob
|
history
diff --git
a/drivers/net/gianfar.c
b/drivers/net/gianfar.c
index 6a38800be3f109fd10d6a472517902c765f64572..65f55877be95c4c9e5d411e0bc23888b6d5c0a7a 100644
(file)
--- a/
drivers/net/gianfar.c
+++ b/
drivers/net/gianfar.c
@@
-289,9
+289,9
@@
static int gfar_of_init(struct net_device *dev)
id = of_get_property(phy, "reg", NULL);
of_node_put(phy);
- of_node_put(mdio);
fsl_pq_mdio_bus_name(bus_name, mdio);
+ of_node_put(mdio);
snprintf(priv->phy_bus_id, sizeof(priv->phy_bus_id), "%s:%02x",
bus_name, *id);
}