drm/nouveau: testing the wrong variable
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 18 Oct 2011 06:07:51 +0000 (09:07 +0300)
committerBen Skeggs <bskeggs@redhat.com>
Wed, 9 Nov 2011 22:59:43 +0000 (08:59 +1000)
memtimings is a valid pointer here, the intent was to test for
kcalloc() failure.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_perf.c

index 9f178aa94162cdc69ac943066272fd3ba899a062..33d03fbf00df56c7523bf8909168d267f0a1d197 100644 (file)
@@ -239,7 +239,7 @@ nouveau_perf_init(struct drm_device *dev)
        if(version == 0x15) {
                memtimings->timing =
                                kcalloc(entries, sizeof(*memtimings->timing), GFP_KERNEL);
-               if(!memtimings) {
+               if (!memtimings->timing) {
                        NV_WARN(dev,"Could not allocate memtiming table\n");
                        return;
                }