ppp: Destroy the mutex when cleanup
authorGao Feng <gfree.wind@vip.163.com>
Tue, 31 Oct 2017 10:25:37 +0000 (18:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Nov 2017 12:21:02 +0000 (21:21 +0900)
The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the
good readbility, it's better to invoke it in exit func when the init
func invokes mutex_init.

Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Acked-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp/ppp_generic.c

index af7f93ed1487a1687982c46a168a79d28b618027..44891335f9afeb5b5bca5d7ed1ad4219d4c40186 100644 (file)
@@ -960,6 +960,7 @@ static __net_exit void ppp_exit_net(struct net *net)
        unregister_netdevice_many(&list);
        rtnl_unlock();
 
+       mutex_destroy(&pn->all_ppp_mutex);
        idr_destroy(&pn->units_idr);
 }