r8169: remove not needed call to dma_sync_single_for_device
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 27 Jun 2019 21:19:09 +0000 (23:19 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 29 Jun 2019 19:29:39 +0000 (12:29 -0700)
DMA_API_HOWTO.txt includes an example explaining when
dma_sync_single_for_device() is not needed, and that example matches
our use case. The buffer isn't changed by the CPU and direction is
DMA_FROM_DEVICE, so we can remove the call to
dma_sync_single_for_device().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index 1b5f125e1b6c3d14909be94e63deebe6a7677c28..a73f2532115bbec57ddfc3bcae901c91e4a87204 100644 (file)
@@ -5785,7 +5785,6 @@ static struct sk_buff *rtl8169_try_rx_copy(void *data,
        skb = napi_alloc_skb(&tp->napi, pkt_size);
        if (skb)
                skb_copy_to_linear_data(skb, data, pkt_size);
-       dma_sync_single_for_device(d, addr, pkt_size, DMA_FROM_DEVICE);
 
        return skb;
 }