fw_cfg: fix sparse warning reading FW_CFG_ID
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 28 Feb 2018 15:06:07 +0000 (16:06 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 20 Mar 2018 01:17:38 +0000 (03:17 +0200)
Use a restricted type for reading FW_CFG_ID, fixing sparse warning:

drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/firmware/qemu_fw_cfg.c

index 7978844f6b37bd24213c44500ca5032ef1810c2a..0eb155fdfb35939fbdb703663be35ad468f977cd 100644 (file)
@@ -530,6 +530,7 @@ static inline void fw_cfg_kobj_cleanup(struct kobject *kobj)
 static int fw_cfg_sysfs_probe(struct platform_device *pdev)
 {
        int err;
+       __le32 rev;
 
        /* NOTE: If we supported multiple fw_cfg devices, we'd first create
         * a subdirectory named after e.g. pdev->id, then hang per-device
@@ -555,8 +556,8 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev)
                goto err_probe;
 
        /* get revision number, add matching top-level attribute */
-       fw_cfg_read_blob(FW_CFG_ID, &fw_cfg_rev, 0, sizeof(fw_cfg_rev));
-       fw_cfg_rev = le32_to_cpu(fw_cfg_rev);
+       fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
+       fw_cfg_rev = le32_to_cpu(rev);
        err = sysfs_create_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
        if (err)
                goto err_rev;