scsi: ufs: fix leakage during link off state

Currently when we try to put the link in off/disabled state during
suspend, it seems link is not being kept in low power mode.
This patch fixes the issue by putting the link in hibern8 first
(so device also puts the link in low power mode) and then stop the
host controller.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 305210fda370859f493785bada6d2129289f018c..93cc02f2d48edc34c0f805621f75e956105d853b 100644 (file)
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5687,6 +5687,16 @@ static int ufshcd_link_state_transition(struct ufs_hba *hba,
        else if ((req_link_state == UIC_LINK_OFF_STATE) &&
                   (!check_for_bkops || (check_for_bkops &&
                    !hba->auto_bkops_enabled))) {
+               /*
+                * Let's make sure that link is in low power mode, we are doing
+                * this currently by putting the link in Hibern8. Otherway to
+                * put the link in low power mode is to send the DME end point
+                * to device and then send the DME reset command to local
+                * unipro. But putting the link in hibern8 is much faster.
+                */
+               ret = ufshcd_uic_hibern8_enter(hba);
+               if (ret)
+                       goto out;
                /*
                 * Change controller state to "reset state" which
                 * should also put the link in off/reset state