drivers: net: ns83820: use setup_timer() helper.
authorAllen Pais <allen.lkml@gmail.com>
Thu, 21 Sep 2017 17:04:34 +0000 (22:34 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Sep 2017 18:44:40 +0000 (11:44 -0700)
Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/natsemi/ns83820.c

index 729095db3e08680b07489f7cb46eb6784a722394..99d3c7884a4a0209dcb9dc39081521175f52dd59 100644 (file)
@@ -1652,9 +1652,7 @@ static int ns83820_open(struct net_device *ndev)
        writel(0, dev->base + TXDP_HI);
        writel(desc, dev->base + TXDP);
 
-       init_timer(&dev->tx_watchdog);
-       dev->tx_watchdog.data = (unsigned long)ndev;
-       dev->tx_watchdog.function = ns83820_tx_watch;
+       setup_timer(&dev->tx_watchdog, ns83820_tx_watch, (unsigned long)ndev);
        mod_timer(&dev->tx_watchdog, jiffies + 2*HZ);
 
        netif_start_queue(ndev);        /* FIXME: wait for phy to come up */