sd: Fix discard granularity when LBPRZ=1
authorMartin K. Petersen <martin.petersen@oracle.com>
Sat, 5 Mar 2016 22:52:02 +0000 (17:52 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 14 Mar 2016 19:50:06 +0000 (15:50 -0400)
Commit 397737223c59 ("sd: Make discard granularity match logical block
size when LBPRZ=1") accidentally set the granularity to one byte instead
of one logical block on devices that provide deterministic zeroes after
UNMAP.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Ewan Milne <emilne@redhat.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Fixes: 397737223c59e89dca7305feb6528caef8fbef84
Cc: <stable@vger.kernel.org> #v4.4+
drivers/scsi/sd.c

index d749da765df141d7aa66ef2a31e591f6cbc94fed..5a5457ac9cdb4560a29be20d28f3a31b4556b578 100644 (file)
@@ -648,7 +648,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode)
         */
        if (sdkp->lbprz) {
                q->limits.discard_alignment = 0;
-               q->limits.discard_granularity = 1;
+               q->limits.discard_granularity = logical_block_size;
        } else {
                q->limits.discard_alignment = sdkp->unmap_alignment *
                        logical_block_size;