PNPACPI: pnpacpi_encode_ext_irq() wrongly set "irq" instead of "extended_irq"
authorBjorn Helgaas <bjorn.helgaas@hp.com>
Mon, 28 Apr 2008 22:33:59 +0000 (16:33 -0600)
committerLen Brown <len.brown@intel.com>
Tue, 29 Apr 2008 07:22:18 +0000 (03:22 -0400)
pnpacpi_encode_ext_irq() should set resource->data.extended_irq, not
resource->data.irq.

This has been wrong since at least 2.6.12.  I haven't seen any bug
reports, but it's clearly incorrect.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/pnp/pnpacpi/rsparser.c

index 98cbc9f18eed36f281a00893e3ad0df58cfb0873..4ce754ab14fd7fd2a918dc2e7a43fb72d01aee79 100644 (file)
@@ -820,9 +820,9 @@ static void pnpacpi_encode_ext_irq(struct acpi_resource *resource,
        resource->data.extended_irq.triggering = triggering;
        resource->data.extended_irq.polarity = polarity;
        if (triggering == ACPI_EDGE_SENSITIVE)
-               resource->data.irq.sharable = ACPI_EXCLUSIVE;
+               resource->data.extended_irq.sharable = ACPI_EXCLUSIVE;
        else
-               resource->data.irq.sharable = ACPI_SHARED;
+               resource->data.extended_irq.sharable = ACPI_SHARED;
        resource->data.extended_irq.interrupt_count = 1;
        resource->data.extended_irq.interrupts[0] = p->start;
 }