block: remove duplicate initialization
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Thu, 16 Aug 2018 22:45:29 +0000 (15:45 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 17 Aug 2018 18:33:36 +0000 (12:33 -0600)
This patch removes the duplicate initialization of q->queue_head
in the blk_alloc_queue_node(). This removes the 2nd initialization
so that we preserve the initialization order same as declaration
present in struct request_queue.

Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c

index 7aeef19704f2e220ceed5a6e03d737ba67f36da5..5832c4003cfb7d09974acd02c1e7aaf3ac0c52a8 100644 (file)
@@ -1036,7 +1036,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id,
                    laptop_mode_timer_fn, 0);
        timer_setup(&q->timeout, blk_rq_timed_out_timer, 0);
        INIT_WORK(&q->timeout_work, NULL);
-       INIT_LIST_HEAD(&q->queue_head);
        INIT_LIST_HEAD(&q->timeout_list);
        INIT_LIST_HEAD(&q->icq_list);
 #ifdef CONFIG_BLK_CGROUP