scsi: scsi_transport_fc: use 64-bit timestamps consistently
authorArnd Bergmann <arnd@arndb.de>
Mon, 18 Jun 2018 15:29:51 +0000 (17:29 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 26 Jun 2018 15:58:07 +0000 (11:58 -0400)
The get_seconds() helper returns an 'unsigned long' value, which can
overflow on 32-bit architectures. Since the interface we pass it into
already uses a 64-bit type, we can just use ktime_get_real_seconds()
instead.

While we generally prefer local timestamps in CLOCK_MONOTONIC format
(ktime_get_seconds), this keeps using the CLOCK_REALTIME version in order
to maintain compatibility with existing code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_fc.c

index 1da3d71e9f61f784e8131093bd5378d94bb98745..bb6de88aa72479b627ecf59c3fdd41d950aaa8e5 100644 (file)
@@ -567,7 +567,7 @@ fc_host_post_event(struct Scsi_Host *shost, u32 event_number,
 
        INIT_SCSI_NL_HDR(&event->snlh, SCSI_NL_TRANSPORT_FC,
                                FC_NL_ASYNC_EVENT, len);
-       event->seconds = get_seconds();
+       event->seconds = ktime_get_real_seconds();
        event->vendor_id = 0;
        event->host_no = shost->host_no;
        event->event_datalen = sizeof(u32);     /* bytes */
@@ -635,7 +635,7 @@ fc_host_post_vendor_event(struct Scsi_Host *shost, u32 event_number,
 
        INIT_SCSI_NL_HDR(&event->snlh, SCSI_NL_TRANSPORT_FC,
                                FC_NL_ASYNC_EVENT, len);
-       event->seconds = get_seconds();
+       event->seconds = ktime_get_real_seconds();
        event->vendor_id = vendor_id;
        event->host_no = shost->host_no;
        event->event_datalen = data_len;        /* bytes */