From: Chunfeng Yun Date: Tue, 24 Apr 2018 02:52:47 +0000 (+0800) Subject: usb: mtu3: remove repeated setting of gadget state X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=00505adef8a8f8fbacd206fe0a4ef59b074c53e4;p=openwrt%2Fstaging%2Fblogic.git usb: mtu3: remove repeated setting of gadget state The usb_add_gadget_udc() will set the gadget state as USB_STATE_NOTATTACHED, so we needn't set it again. Signed-off-by: Chunfeng Yun Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index f05f10f5c171..de0de015eaf0 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -660,14 +660,10 @@ int mtu3_gadget_setup(struct mtu3 *mtu) mtu3_gadget_init_eps(mtu); ret = usb_add_gadget_udc(mtu->dev, &mtu->g); - if (ret) { + if (ret) dev_err(mtu->dev, "failed to register udc\n"); - return ret; - } - usb_gadget_set_state(&mtu->g, USB_STATE_NOTATTACHED); - - return 0; + return ret; } void mtu3_gadget_cleanup(struct mtu3 *mtu)