From: Andy Green Date: Wed, 2 May 2007 11:49:06 +0000 (+0100) Subject: kbuild: scripts/basic/fixdep segfault on pathological string-o-death X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=04c58f8196b386948abf68128605de3d2db3c6ba;p=openwrt%2Fstaging%2Fblogic.git kbuild: scripts/basic/fixdep segfault on pathological string-o-death build scripts: fixdep blows segfault on string CONFIG_MODULE seen The string "CONFIG_MODULE" appearing anywhere in a source file causes fixdep to segfault. This string appeared in the wild in the current mISDN sources (I think they meant CONFIG_MODULES). But it shouldn't segfault (esp as CONFIG_MODULE appeared in a quoted string). Signed-off-by: Andy Green Signed-off-by: Sam Ravnborg --- diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index 6bc7e7cfccf6..8912c0f5460b 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@ -249,6 +249,8 @@ void parse_config_file(char *map, size_t len) found: if (!memcmp(q - 7, "_MODULE", 7)) q -= 7; + if( (q-p-7) < 0 ) + continue; use_config(p+7, q-p-7); } }