From: Felix Fietkau <nbd@nbd.name>
Date: Mon, 20 Sep 2021 16:00:03 +0000 (+0200)
Subject: wireless: only enable proxyarp/isolate for AP vifs
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=06d11bbf1f2b61dcdb1b7088eec539fcd00b28a0;p=project%2Fnetifd.git

wireless: only enable proxyarp/isolate for AP vifs

The settings might be present in the config as leftovers when switching
a vif from AP to sta mode. In that case, they will not be applied by wpad,
so they also must not be used by netifd

Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/wireless.c b/wireless.c
index 29feb6a..fbd42ed 100644
--- a/wireless.c
+++ b/wireless.c
@@ -793,6 +793,13 @@ wireless_interface_init_config(struct wireless_interface *vif)
 	if ((cur = tb[VIF_ATTR_NETWORK]))
 		vif->network = cur;
 
+	cur = tb[VIF_ATTR_MODE];
+	if (cur)
+		vif->ap_mode = !strcmp(blobmsg_get_string(cur), "ap");
+
+	if (!vif->ap_mode)
+		return;
+
 	cur = tb[VIF_ATTR_ISOLATE];
 	if (cur)
 		vif->isolate = blobmsg_get_bool(cur);
@@ -801,9 +808,6 @@ wireless_interface_init_config(struct wireless_interface *vif)
 	if (cur)
 		vif->proxyarp = blobmsg_get_bool(cur);
 
-	cur = tb[VIF_ATTR_MODE];
-	if (cur)
-		vif->ap_mode = !strcmp(blobmsg_get_string(cur), "ap");
 }
 
 /* vlist update call for wireless interface list */