From: Dustin Gathmann Date: Wed, 20 May 2020 23:22:53 +0000 (+0200) Subject: lantiq/xrx200: fix WLAN button actions for Fritzbox 3370 X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=0ee30adb46a87583badd85b69e4ccd7942786374;p=openwrt%2Fstaging%2Frobimarko.git lantiq/xrx200: fix WLAN button actions for Fritzbox 3370 The WLAN button actions are reversed, i.e. pressing the button emits a 'released' action, and vice versa. This can easily be checked by adding logger -t button_action "$BUTTON $ACTION" as the second line of /etc/rc.button/rfkill, and using logread to read the events (assuming the preceding patch has been applied). Defining the GPIO as ACTIVE_LOW corrects this behavior. Signed-off-by: Dustin Gathmann --- diff --git a/target/linux/lantiq/files-4.19/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi b/target/linux/lantiq/files-4.19/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi index 4c4ae1a01f..2c790a488e 100644 --- a/target/linux/lantiq/files-4.19/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi +++ b/target/linux/lantiq/files-4.19/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi @@ -44,7 +44,7 @@ wifi { label = "wlan"; - gpios = <&gpio 29 GPIO_ACTIVE_HIGH>; + gpios = <&gpio 29 GPIO_ACTIVE_LOW>; linux,code = ; }; }; diff --git a/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi b/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi index 4c4ae1a01f..2c790a488e 100644 --- a/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi +++ b/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_avm_fritz3370-rev2.dtsi @@ -44,7 +44,7 @@ wifi { label = "wlan"; - gpios = <&gpio 29 GPIO_ACTIVE_HIGH>; + gpios = <&gpio 29 GPIO_ACTIVE_LOW>; linux,code = ; }; };