From: Mike Frysinger Date: Thu, 15 Nov 2007 00:58:43 +0000 (-0800) Subject: rtc: tweak driver documentation for rtc periodic X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=108b4c3638be251d6b42eaa633e8a6b852b960f0;p=openwrt%2Fstaging%2Fblogic.git rtc: tweak driver documentation for rtc periodic The max_user_freq member is not really meant for RTC drivers to modify, so update the rtc documentation so drivers writers know what is expected of them when handling periodic events. Signed-off-by: Mike Frysinger Acked-by: Alessandro Zummo Cc: David Brownell Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/Documentation/rtc.txt b/Documentation/rtc.txt index c931d613f641..e20b19c1b60d 100644 --- a/Documentation/rtc.txt +++ b/Documentation/rtc.txt @@ -180,9 +180,10 @@ driver returns ENOIOCTLCMD. Some common examples: * RTC_IRQP_SET, RTC_IRQP_READ: the irq_set_freq function will be called to set the frequency while the framework will handle the read for you since the frequency is stored in the irq_freq member of the rtc_device - structure. Also make sure you set the max_user_freq member in your - initialization routines so the framework can sanity check the user - input for you. + structure. Your driver needs to initialize the irq_freq member during + init. Make sure you check the requested frequency is in range of your + hardware in the irq_set_freq function. If you cannot actually change + the frequency, just return -ENOTTY. If all else fails, check out the rtc-test.c driver!